Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add autocomplete=one-time-code. Fixes whatwg/html#3745 #4573

Merged
merged 1 commit into from
Apr 29, 2019

Conversation

hober
Copy link
Contributor

@hober hober commented Apr 26, 2019

See the corresponding issue and web-platform-tests PR.


/acknowledgements.html ( diff )
/form-control-infrastructure.html ( diff )

Copy link
Member

@domenic domenic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, will leave un-merged for a day or two in case anyone else wants to take a look.

<td>One-time code used for verifying user identity
<td>Free-form text, no newlines
<td>123456
<td><span data-x="Control Group Password">Password</span>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For any other reviewers, it turns out this includes input type=text as well: http://localhost:8080/#control-group-password

@sideshowbarker sideshowbarker added the impacts documentation Used by documentation communities, such as MDN, to track changes that impact documentation label Apr 28, 2019
@sideshowbarker
Copy link
Contributor

heads-up @whatwg/documentation

sideshowbarker added a commit to validator/validator that referenced this pull request Apr 28, 2019
@sideshowbarker
Copy link
Contributor

gsnedders pushed a commit to web-platform-tests/wpt that referenced this pull request Apr 29, 2019
@jpmedley
Copy link

jpmedley commented Apr 29, 2019 via email

@zcorpan
Copy link
Member

zcorpan commented Apr 29, 2019

@jpmedley I'm guessing #3745 (comment) is right and nobody else has implemented this yet. Nobody passes the test at this time, though.

The test has been merged; @domenic can you merge this, or are we waiting for something?

@domenic domenic merged commit 43b2455 into whatwg:master Apr 29, 2019
moz-v2v-gh pushed a commit to mozilla/gecko-dev that referenced this pull request Jun 5, 2019
whatwg/html#4573, a=testonly

Automatic update from web-platform-tests
HTML: test autocomplete=one-time-code (#16565)

For whatwg/html#4573
--

wpt-commits: 2fe0c9800f405d92ccc31a0e93bc4a05aac4c81b
wpt-pr: 16565
mykmelez pushed a commit to mykmelez/gecko that referenced this pull request Jun 6, 2019
whatwg/html#4573, a=testonly

Automatic update from web-platform-tests
HTML: test autocomplete=one-time-code (#16565)

For whatwg/html#4573
--

wpt-commits: 2fe0c9800f405d92ccc31a0e93bc4a05aac4c81b
wpt-pr: 16565
marcoscaceres pushed a commit to web-platform-tests/wpt that referenced this pull request Jul 23, 2019
gecko-dev-updater pushed a commit to marco-c/gecko-dev-comments-removed that referenced this pull request Oct 4, 2019
whatwg/html#4573, a=testonly

Automatic update from web-platform-tests
HTML: test autocomplete=one-time-code (#16565)

For whatwg/html#4573
--

wpt-commits: 2fe0c9800f405d92ccc31a0e93bc4a05aac4c81b
wpt-pr: 16565

UltraBlame original commit: c72de4b40e659fc32c1514d12a0c084852e3aac5
gecko-dev-updater pushed a commit to marco-c/gecko-dev-wordified that referenced this pull request Oct 4, 2019
whatwg/html#4573, a=testonly

Automatic update from web-platform-tests
HTML: test autocomplete=one-time-code (#16565)

For whatwg/html#4573
--

wpt-commits: 2fe0c9800f405d92ccc31a0e93bc4a05aac4c81b
wpt-pr: 16565

UltraBlame original commit: c72de4b40e659fc32c1514d12a0c084852e3aac5
gecko-dev-updater pushed a commit to marco-c/gecko-dev-wordified-and-comments-removed that referenced this pull request Oct 4, 2019
whatwg/html#4573, a=testonly

Automatic update from web-platform-tests
HTML: test autocomplete=one-time-code (#16565)

For whatwg/html#4573
--

wpt-commits: 2fe0c9800f405d92ccc31a0e93bc4a05aac4c81b
wpt-pr: 16565

UltraBlame original commit: c72de4b40e659fc32c1514d12a0c084852e3aac5
lencioni added a commit to lencioni/axe-core that referenced this pull request Jun 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
impacts documentation Used by documentation communities, such as MDN, to track changes that impact documentation
Development

Successfully merging this pull request may close these issues.

5 participants